Skip to content

feat: implement deep parsing for BEGIN and START TRANSACTION - #64

Open
Snehil-Shah wants to merge 4 commits into
ProxySQL:mainfrom
Snehil-Shah:txn-stmts
Open

feat: implement deep parsing for BEGIN and START TRANSACTION#64
Snehil-Shah wants to merge 4 commits into
ProxySQL:mainfrom
Snehil-Shah:txn-stmts

Conversation

@Snehil-Shah

@Snehil-Shah Snehil-Shah commented Aug 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Adds coverage for transactional statements required in #63.

Summary by CodeRabbit

  • New Features

    • Added enhanced parsing for BEGIN and START TRANSACTION statements.
    • Recognizes transaction modes such as isolation level, read-only, and consistent snapshot options across supported SQL dialects.
    • Produces consistent, canonical formatting for supported transaction statements.

  • Bug Fixes

    • Improved handling of incomplete, unsupported, and dialect-specific transaction clauses.
    • Transaction statement digests are now consistent regardless of keyword casing.

  • Documentation

    • Clarified transaction statement classification and parsing tiers.

@Snehil-Shah
docs: add spec
0af0b39 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 minutes.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 20c218c2-f36f-40f6-9fb6-bcf1176a0252

📥 Commits

Reviewing files that changed from the base of the PR and between b20c1cc and 634012a.

📒 Files selected for processing (8)
  • README.md
  • docs/superpowers/specs/2026-08-16-transaction-statement-node-design.md
  • include/sql_parser/common.h
  • include/sql_parser/emitter.h
  • include/sql_parser/parser.h
  • src/sql_parser/parser.cpp
  • tests/test_digest.cpp
  • tests/test_misc_stmts.cpp

Comment @coderabbitai help to get the list of available commands.

@Snehil-Shah
docs: update spec to use values to store introducer
5f1607e 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah
feat: implement deep parsing for BEGIN and START TRANSACTION
4a861e0 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah
Snehil-Shah marked this pull request as ready for review August 24, 2026 17:38
@Snehil-Shah

Snehil-Shah commented Aug 24, 2026

Copy link
Copy Markdown
Author

cc @renecannao

@Snehil-Shah
docs: update README
634012a 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Snehil-Shah